Open
Conversation
alexr00
reviewed
Mar 31, 2026
Comment on lines
+272
to
+274
| if (![ThemeSettingDefaults.COLOR_THEME_DARK, ThemeSettingDefaults.COLOR_THEME_LIGHT].includes(this.settings.colorTheme)) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Not sure I understand this. We return early if the current theme is not one of the 2026 themes?
Contributor
Author
There was a problem hiding this comment.
This is to test that the user is on the default, which is now Dark/Light 2026.
| const keepTheme = await new Promise(resolve => { | ||
| this.notificationService.prompt( | ||
| Severity.Info, | ||
| nls.localize({ key: 'themeUpdatedNotification', comment: ['{0} is the name of the new default theme'] }, "VS Code now ships with a new default theme '{0}'. Do you want to give it a try?", this.getColorTheme().label), |
Member
There was a problem hiding this comment.
Do you want to give it a try? sounds to me like you haven't already switched the theme, but the action "Keep it" sounds like you have already switched the theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.