Fix invalid outline navigation in search editor#317261
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Co-authored-by: dmitrivMS <9581278+dmitrivMS@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix invalid outline in search editor
Fix invalid outline navigation in search editor
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking an outline entry for a search editor opened a new tab and failed with
Unable to resolve resource search-editor:#0.<random>. The search editor's underlying text model uses an internalsearch-editor:URI that has no resource-based editor resolver (only the.code-searchfile extension is registered), soDocumentSymbolsOutline.revealcould not round-trip throughIEditorService.openEditor.Changes
documentSymbolsOutline.ts: Inreveal, when the outline's model URI matches the source editor's current model and the user isn't requesting side-by-side, apply the selection in place onthis._editorinstead of delegating toICodeEditorService.openCodeEditor. This mirrors the existing in-place special case used byCodeEditorService.doOpenCodeEditorFromDifffor diff editors and avoids resolving a resource that the editor service cannot open.Side-by-side opens and cross-editor navigation paths are unchanged.