Fix resolveCodeLens calling validateRange on disposed model#317263
Draft
Copilot wants to merge 2 commits into
Draft
Fix resolveCodeLens calling validateRange on disposed model#317263Copilot wants to merge 2 commits into
resolveCodeLens calling validateRange on disposed model#317263Copilot wants to merge 2 commits into
Conversation
…tures Co-authored-by: dmitrivMS <9581278+dmitrivMS@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix
Fix May 19, 2026
resolveCodeLens invoking validateRange on disposed modelresolveCodeLens calling validateRange on disposed model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MainThreadLanguageFeatures.resolveCodeLensawaits the extension host's$resolveCodeLensand then callsmodel.validateRange(result.range). If the editor/model is disposed during the await, this throwsModel is disposed!.src/vs/workbench/api/browser/mainThreadLanguageFeatures.ts: extend the existing post-await guard to also bail out when the model is disposed.