Remove project setup info tool#317284
Open
alexr00 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the experimental getProjectSetupInfo tool and its associated configuration flag (chat.projectSetupInfoSkill.enabled) from the Copilot extension, switching the new-workspace flow over to the always-on prompt-based skills (project-setup-info-local / project-setup-info-context7) gated only by the useContext7 setting. It also adds an unrelated integration test in vscode-api-tests for the _developer.getConfigurationInformation command, verifying it enables disabled built-in extensions before dumping their config.
Changes:
- Delete
projectSetupInfoTool.tsxand its registration, plus theProjectSetupInfoSkillEnabledconfig / package.json setting / nls string. - Simplify the
whenclauses on the project-setup-infochatSkillsso they are always enabled (other than the existinguseContext7toggle). - Add a regression integration test for
_developer.getConfigurationInformationagainst the disabledGitHub.copilot-chatbuilt-in extension.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/tools/node/newWorkspace/projectSetupInfoTool.tsx | Deletes the project setup info tool implementation. |
| extensions/copilot/src/extension/tools/node/allTools.ts | Removes the import that registered the deleted tool. |
| extensions/copilot/src/platform/configuration/common/configurationService.ts | Removes the ProjectSetupInfoSkillEnabled config key. |
| extensions/copilot/package.json | Removes the tool contribution, its config schema, and updates chatSkills when clauses. |
| extensions/copilot/package.nls.json | Removes the localization string for the deleted setting. |
| extensions/vscode-api-tests/src/singlefolder-tests/configuration.test.ts | Adds an (unrelated) integration test for _developer.getConfigurationInformation. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 3
| import './newNotebookTool'; | ||
| import './newWorkspace/newWorkspaceTool'; | ||
| import './newWorkspace/projectSetupInfoTool'; | ||
| import './notebookSummaryTool'; |
| @@ -596,29 +596,6 @@ | |||
| "enable_other_tool_get_project_setup_info" | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.