Fix BulkTextEdit to prevent applying edits when document version has advanced#317286
Open
dbaeumer wants to merge 4 commits into
Open
Fix BulkTextEdit to prevent applying edits when document version has advanced#317286dbaeumer wants to merge 4 commits into
dbaeumer wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a correctness issue in bulk text editing where version checks could be bypassed when edits are minimized asynchronously, leading to edits being applied even after the underlying document version has advanced (issue #317275).
Changes:
- Preserve the original
versionIdwhen converting computed “more minimal” edits intoResourceTextEdits so downstream validation can reject stale edits. - Add inline commentary explaining the intent of propagating
versionIdthrough the minimization path.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/bulkEdit/browser/bulkTextEdits.ts | Propagates versionId into minimized edits so ModelEditTask.validate() can detect model version drift and prevent stale edit application. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes ensure that the BulkTextEdit class correctly handles document versioning by validating the version before applying edits. This prevents edits from being applied when the text document version has advanced, addressing the issue reported in #317275.
Fixes #317275