Cross-platform support #518

vedantmgoyal9 · 2024-02-22T06:17:46Z

Have you signed the Contributor License Agreement?
Are you working against an Issue?
- Resolves Remove x86 package from msixbundle #80
- Resolves Port to Linux and macOS #370
- Resolves Running on not-Windows? #160

Added support for win-arm64,osx-arm64,linux-arm64,linux-x64.
Directories on Linux/macOS:
- Settings: ~/.config/wingetcreate/settings.json,~/.config/wingetcreate/settings.json.backup
- Logs: ~/.config/wingetcreate/DiagOutputDir/<file>.txt
- Installer downloads: /tmp/wingetcreate/

Microsoft Reviewers: Open in CodeFlow

sitiom

Directories on Linux/macOS:

Settings: ~/.wingetcreate/settings.json,~/.wingetcreate/settings.json.backup

Logs: ~/.wingetcreate/DiagOutputDir/<file>.txt

Installer downloads: /tmp/wingetcreate/

It would be nice to follow the XDG Base Directory spec like most apps already do to avoid clutter in the home directory (Example: ~/.config/winget-create)

ryfu-msft · 2024-07-03T21:41:40Z

/azp run

azure-pipelines · 2024-07-03T21:41:52Z

Azure Pipelines successfully started running 1 pipeline(s).

vedantmgoyal9 · 2024-11-23T09:07:09Z

@florelis can you please review this?

florelis

(Haven't finished reading through the whole PR yet)

@ryfu-msft could you also review this since you have more context? At least the sections for package parsing

Main comments so far:

Writing the token in plain text is risky
We need to verify the internal protocols we have for using new OSS projects
For computing the PFN I'd like an official source of the algorithm or the ok from MSIX team. I don't want this repo to become the official MS source for how these are computed

README.md

florelis · 2024-11-25T19:37:33Z

.gitmodules

+  path = src/WingetCreateCore/Common/Msi/rust-msi\
+	# TODO: Switch to mdsteele/rust-msi once the PR is merged
+	# https://github.com/mdsteele/rust-msi/pull/18
+  url = https://github.com/vedantmgoyal9/rust-msi


I don't think we can just include an external repository as a submodule and then build it blindly; that seems like a security risk. At the very least, it should point to a specific commit so that we cannot get unknown, unexpected changes.

We have internal policies/procedures for evaluating new OSS we use, but I'm not that familiar with them. I need review them or ask someone else on the team..

Pinned to a specific commit.

I think that is still pointing to a branch, which can get newer commits at any time

@florelis https://github.com/vedantmgoyal9/winget-create/tree/main/src/WingetCreateCore/Common/Msi

src/WingetCreateCLI/Commands/SettingsCommand.cs

src/WingetCreateCLI/Common.cs

src/WingetCreateCore/Common/PackageParser.cs

src/WingetCreateCore/Common/MsixAndAppx.cs

florelis · 2024-11-25T23:22:17Z

src/WingetCreateCore/Common/MsixAndAppx.cs

+            // Generate the hash part of the package family name
+            var publisherSha256 = SHA256.HashData(Encoding.Unicode.GetBytes(identityNode.Attributes["Publisher"].Value));
+            var binaryString = string.Concat(publisherSha256.Take(8).Select(c => Convert.ToString(c, 2).PadLeft(8, '0'))) + '0'; // representing 65-bits = 13 * 5
+            var encodedPublisherId = string.Concat(Enumerable.Range(0, binaryString.Length / 5).Select(i => "0123456789ABCDEFGHJKMNPQRSTVWXYZ".Substring(Convert.ToInt32(binaryString.Substring(i * 5, 5), 2), 1)));


Where did this come from? If there is an official source we should link it in a comment for future reference. If not, we'll need to ask the MSIX team internally to confirm this is right and that it is appropriate for us to write publicly.

I've added a comment referencing the source. By the way, the same algorithm is also used in YamlCreate.ps1 - https://github.com/microsoft/winget-pkgs/blob/master/Tools/YamlCreate.ps1#L853-L870.

Co-authored-by: Flor Chacón <14323496+florelis@users.noreply.github.com>

pjmagee · 2025-03-14T00:58:52Z

If i can use this tool on linux, that would be amazing, I have a container based workflow CI that would benefit a lot being able to publish to winget

microsoft-github-policy-service bot added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Feb 22, 2024

vedantmgoyal9 marked this pull request as ready for review March 28, 2024 17:53

vedantmgoyal9 requested review from a team, ryfu-msft and yao-msft and removed request for a team March 28, 2024 17:53

sitiom suggested changes Mar 29, 2024

View reviewed changes

microsoft-github-policy-service bot added Needs-Author-Feedback and removed Needs-Author-Feedback labels Mar 29, 2024

vedantmgoyal9 force-pushed the main branch 3 times, most recently from 8e6401a to aeb188c Compare June 22, 2024 19:36

vedantmgoyal9 force-pushed the main branch 4 times, most recently from ceed3ee to d5bc8c9 Compare July 10, 2024 08:44

vedantmgoyal9 force-pushed the main branch 5 times, most recently from ce1584e to 07a73da Compare September 5, 2024 11:14

vedantmgoyal9 force-pushed the main branch 7 times, most recently from b520493 to 0cb05ea Compare October 19, 2024 22:26

vedantmgoyal9 restored the main branch November 20, 2024 09:06

vedantmgoyal9 reopened this Nov 20, 2024

vedantmgoyal9 deleted the branch microsoft:main November 20, 2024 09:07

vedantmgoyal9 closed this Nov 20, 2024

vedantmgoyal9 deleted the main branch November 20, 2024 09:07

vedantmgoyal9 restored the main branch November 20, 2024 09:08

vedantmgoyal9 reopened this Nov 20, 2024

vedantmgoyal9 force-pushed the main branch 8 times, most recently from 94698e3 to 072fb23 Compare November 22, 2024 20:05

Cross-platform support

a60d338

vedantmgoyal9 force-pushed the main branch from 072fb23 to a60d338 Compare November 22, 2024 20:10

vedantmgoyal9 added 2 commits November 24, 2024 10:37

Discard changes to src/WingetCreateCLI/Models/SettingsModel.cs

0bc6a38

Discard changes to CONTRIBUTING.md

bea7944

florelis reviewed Nov 25, 2024

View reviewed changes

Apply suggestions from code review

950c506

Co-authored-by: Flor Chacón <14323496+florelis@users.noreply.github.com>

vedantmgoyal9 force-pushed the main branch 2 times, most recently from f283ecf to 04929d3 Compare November 26, 2024 12:32

Address review comments

8c8c70e

vedantmgoyal9 force-pushed the main branch from 04929d3 to 8c8c70e Compare November 26, 2024 12:35

Use XDG base directory specification

4326571

vedantmgoyal9 requested a review from florelis November 26, 2024 13:15

Teri68 approved these changes Oct 29, 2025

View reviewed changes

Cross-platform support #518

Are you sure you want to change the base?

Cross-platform support #518

Uh oh!

Conversation

vedantmgoyal9 commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Microsoft Reviewers: Open in CodeFlow

Uh oh!

sitiom left a comment

Choose a reason for hiding this comment

Uh oh!

ryfu-msft commented Jul 3, 2024

Uh oh!

azure-pipelines bot commented Jul 3, 2024

Uh oh!

vedantmgoyal9 commented Nov 23, 2024

Uh oh!

florelis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

florelis Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

vedantmgoyal9 Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

florelis Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

vedantmgoyal9 Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

florelis Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

vedantmgoyal9 Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

pjmagee commented Mar 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

vedantmgoyal9 commented Feb 22, 2024 •

edited

Loading