Conversation
Manoj-Kesana
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Azure Network Security assessment test 25550 to avoid reporting a failure when no Azure Firewall Premium policies exist in the tenant/subscriptions.
Changes:
- Replaces the “❌ No Azure Firewall Premium policies found…” failure output with a
NotApplicableskip path. - Adds a verbose diagnostic message and returns early when no Premium policies are discovered.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
alexandair
requested changes
Mar 5, 2026
Collaborator
alexandair
left a comment
alexandair
left a comment
There was a problem hiding this comment.
@Manoj-Kesana Please, address my feedback.
As we are already changing this test, should we replace Invoke-AzRestMethod with ARG query like we do for other similar tests?
alexandair
requested changes
Mar 10, 2026
Collaborator
alexandair
left a comment
alexandair
left a comment
There was a problem hiding this comment.
@Manoj-Kesana Please, address my feedback.
alexandair
requested changes
Mar 12, 2026
Collaborator
alexandair
left a comment
alexandair
left a comment
There was a problem hiding this comment.
@Manoj-Kesana Please, address my feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #961