Conversation
Co-authored-by: micycle1 <9304234+micycle1@users.noreply.github.com>
Co-authored-by: micycle1 <9304234+micycle1@users.noreply.github.com>
|
@copilot double-check your proposed changes vs the diff. |
Co-authored-by: micycle1 <9304234+micycle1@users.noreply.github.com>
I re-checked the Java port against the upstream 1.3.0→1.4.0 C# diff and found one missed parity condition in |
|
@codex[agent] There's a diff in Clipper.Engine.cs which hasn't (as as i can tell) been replicated in ClipperBase.java -- changes to IntersectEdges(), etc. |
Synced IntersectEdges with the C# 1.4.0 diff—method is now void with early returns instead of returning an OutPt, matching upstream logic (d37acbf). |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63c79152e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (cnt == 1) { | ||
| Point64 pt = p.get(0); | ||
| if (deltaCallback != null) { | ||
| groupDelta = deltaCallback.calculate(p, normals, 0, 0); |
There was a problem hiding this comment.
Reset normals before invoking single-point delta callbacks
In DoGroupOffset, the new cnt == 1 callback path calls deltaCallback.calculate(p, normals, 0, 0) without rebuilding or clearing normals, so if a multi-vertex path was processed just before, the callback receives stale normals from the previous path. This causes incorrect variable offsets for the single-point path (and can break callbacks that assume path_norms matches the current path). Please clear normals or pass an empty normals list before this callback.
Useful? React with 👍 / 👎.
Co-authored-by: micycle1 <9304234+micycle1@users.noreply.github.com>
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.