Skip to content

fix versionId null check in getPresignedObjectUrl properly #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshavardhana merged 3 commits into from
Apr 3, 2026
+19 −1
Merged

fix versionId null check in getPresignedObjectUrl properly #1693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f1b023
fix: invalid condition
Paw565pl Mar 24, 2026
0fe755c
test: cover regression with assertion
Paw565pl Mar 24, 2026
178cfd3
refactor: parse url with okhttp
Paw565pl Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/main/java/io/minio/MinioAsyncClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,7 @@ public String getPresignedObjectUrl(GetPresignedObjectUrlArgs args) throws Minio
}

Http.QueryParameters queryParams = new Http.QueryParameters();
if (args.versionId() == null) queryParams.put("versionId", args.versionId());
if (args.versionId() != null) queryParams.put("versionId", args.versionId());

Credentials credentials = provider == null ? null : provider.fetch();
if (credentials != null && credentials.sessionToken() != null) {
Expand Down
18 changes: 18 additions & 0 deletions functional/TestMinioClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@
import java.util.concurrent.TimeUnit;
import java.util.stream.Collectors;
import okhttp3.Headers;
import okhttp3.HttpUrl;
import okhttp3.MultipartBody;
import okhttp3.Request;
import okhttp3.RequestBody;
Expand Down Expand Up @@ -1270,6 +1271,23 @@ public void testGetPresignedObjectUrlForGet() throws Exception {
.build(),
expectedChecksum);

testTags = "[GET, versionId]";
String versionId = "dummy-version";
String urlString =
client.getPresignedObjectUrl(
GetPresignedObjectUrlArgs.builder()
.method(Http.Method.GET)
.bucket(bucketName)
.object(objectName)
.versionId(versionId)
.build());
HttpUrl url = HttpUrl.parse(urlString);
Assertions.assertNotNull(url, "generated url is not valid");
Assertions.assertEquals(
versionId,
url.queryParameter("versionId"),
"versionId query param does not match the expected value");

testTags = "[GET, expiry, query params]";
Map<String, String> queryParams = new HashMap<>();
queryParams.put("response-content-type", "application/json");
Expand Down
Loading