fix: skip functional tests on HTTP 405/501 responses#1694
Open
harshavardhana wants to merge 1 commit intomasterfrom
Open
fix: skip functional tests on HTTP 405/501 responses#1694harshavardhana wants to merge 1 commit intomasterfrom
harshavardhana wants to merge 1 commit intomasterfrom
Conversation
Use HTTP status codes directly instead of checking error code strings, so tests are properly skipped when APIs return 405 (Method Not Allowed) or 501 (Not Implemented).
balamurugana
reviewed
Apr 4, 2026
Comment on lines
+433
to
+434
| int code = ((ErrorResponseException) e).response().code(); | ||
| if (code == 405 || code == 501) { |
Member
There was a problem hiding this comment.
MinioClient already returns MethodNotAllowed S3 error code for 405 and 501 HTTP status code.
Suggested change
| int code = ((ErrorResponseException) e).response().code(); | |
| if (code == 405 || code == 501) { | |
| if (((ErrorResponseException) e).errorResponse().code().equals("NotImplemented") || (ErrorResponseException) e).errorResponse().code().equals("MethodNotAllowed")) { |
Comment on lines
+713
to
+714
| int code = ((ErrorResponseException) e).response().code(); | ||
| if (code == 405 || code == 501) { |
Member
There was a problem hiding this comment.
MinioClient already returns MethodNotAllowed S3 error code for 405 and 501 HTTP status code.
Suggested change
| int code = ((ErrorResponseException) e).response().code(); | |
| if (code == 405 || code == 501) { | |
| if (((ErrorResponseException) e).errorResponse().code().equals("NotImplemented") || (ErrorResponseException) e).errorResponse().code().equals("MethodNotAllowed")) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use HTTP status codes directly instead of checking error
code strings, so tests are properly skipped when APIs
return 405 (Method Not Allowed) or 501 (Not Implemented).