Fix scheduler exception propagation to Python #2964
Closed
+40
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
std::exception_ptrstorage inStreamThreadto capture exceptions thrown during task executionsynchronize()so they propagate asRuntimeErrorto PythonProblem
When
mx.linalg.solveis called with a singular matrix, the LU factorization throws astd::runtime_errorinside the scheduler worker thread. Previously, this exception was not caught, causing the process to crash with SIGABRT instead of raising a catchable Python exception.Test plan
test_linalg.py::test_solvethat verifies singular matrix raisesRuntimeErrorFixes #2888