feat: Enable CI for release branches#352
Conversation
Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Dockerfile to add a thin /bin/bash wrapper using a heredoc COPY to support environments that wrap tasks in bash -c, and modifies the PYTHONPATH environment variable. Feedback suggests correcting an inaccurate comment in the Dockerfile that states /bin/bash is created 'via RUN' instead of 'via COPY', and warns against completely overwriting PYTHONPATH instead of appending to it to avoid discarding pre-configured paths.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # enroot/pyxis starts containers through /bin/sh (switchroot); nv-sflow's srun | ||
| # operator wraps every task in `bash -c` (hardcoded in srun.py). This distroless | ||
| # runtime base has neither, so add a static busybox as /bin/sh, then create | ||
| # /bin/bash as a thin sh-wrapper via RUN (valid once /bin/sh exists above). |
There was a problem hiding this comment.
The comment states that /bin/bash is created "via RUN", but the implementation actually uses a heredoc COPY (COPY --chmod=755 <<'EOF' /bin/bash). Updating the comment to accurately reflect the use of COPY will prevent confusion for future maintainers.
# enroot/pyxis starts containers through /bin/sh (switchroot); nv-sflow's srun
# operator wraps every task in `bash -c` (hardcoded in srun.py). This distroless
# runtime base has neither, so add a static busybox as /bin/sh, then create
# /bin/bash as a thin sh-wrapper via COPY.
|
|
||
| # Make lcb_serve.py available as a module | ||
| ENV PYTHONPATH="/app:${PYTHONPATH}" | ||
| ENV PYTHONPATH="/app" |
There was a problem hiding this comment.
Overwriting PYTHONPATH completely instead of appending to it can discard any pre-configured paths set by the base image or parent environment, which may lead to unexpected import errors. It is safer to preserve the existing PYTHONPATH by appending or prepending to it.
ENV PYTHONPATH="/app:${PYTHONPATH}"
1 participant
What does this PR do?
Enables CI for branches of the form
release/**.Type of change
Related issues
Testing
Checklist