Skip to content

refactor: rename multi-turn to agentic inference#355

Merged
hvagadia merged 2 commits into
mlcommons:mainfrom
hvagadia:hvagadia/agentic-inference-rename
Jun 15, 2026
Merged

refactor: rename multi-turn to agentic inference#355
hvagadia merged 2 commits into
mlcommons:mainfrom
hvagadia:hvagadia/agentic-inference-rename

Conversation

@hvagadia

Copy link
Copy Markdown
Collaborator

What does this PR do?

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor/cleanup

Related issues

Testing

  • Tests added/updated
  • All tests pass locally
  • Manual testing completed

Checklist

  • Code follows project style
  • Pre-commit hooks pass
  • Documentation updated (if needed)

@hvagadia hvagadia requested a review from a team June 13, 2026 03:02
@github-actions

github-actions Bot commented Jun 13, 2026

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames "multi-turn" benchmarking terminology to "agentic inference" across the entire codebase, including configuration schemas, dataset loaders, load strategies, documentation, and tests. The review comments identify minor grammatical and redundancy issues in the updated documentation and scripts, as well as an inconsistency in the JSON schema title that should be updated to match the renamed files.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread examples/10_Agentic_Inference/README.md Outdated
Comment thread scripts/agentic_inference_isl_precompute.py Outdated
Comment thread scripts/agentic_inference_dataset_schema.json

@tianmu-li tianmu-li left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the few grammar issues already pointed out.

@hvagadia hvagadia requested a review from a team June 14, 2026 23:16
@hvagadia hvagadia merged commit 0abc4f4 into mlcommons:main Jun 15, 2026
7 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants