Skip to content

Adapt home and repositories pages from umich-arclight#22

Merged
ssciolla merged 56 commits into
mainfrom
ARC-135-repositories-view
Jun 23, 2026
Merged

Adapt home and repositories pages from umich-arclight#22
ssciolla merged 56 commits into
mainfrom
ARC-135-repositories-view

Conversation

@ssciolla

@ssciolla ssciolla commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

rshiggin and others added 30 commits June 12, 2026 14:28
…verriding templates for index, home, adding HomepageHelper and CatalogHelper, adding image config and files, adding um_arclight translation file
…ion.bootstrap; fix spacing in _home.html.erb
}

// Arclight, imported from arclight frontend package
@import 'arclight/app/assets/stylesheets/arclight/application';

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we no longer need this, or was it moved elsewhere?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I've left it out of our update with the assumption we don't need it. To make it easy for now there's just a flat directory, "stylesheets"

Comment thread app/assets/stylesheets/_banners.scss Outdated
Comment thread app/assets/stylesheets/_banners.scss Outdated

/* ---------------------- */
/* SEARCH BOX ON HOMEPAGE */
/* ---------------------- */

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

@rshiggin rshiggin Jun 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the large comment or the search bar itself? Doesn't it make sense to keep it under "Find Archival Materials."

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sorry, I think I just meant remove the commented code above this, not the Search box stuff.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When CSS is minified in production all comments are removed. These comments are helpful in development.

Comment thread app/helpers/contact_link_helper.rb
Comment thread app/helpers/dul_arclight_helper.rb Outdated
Comment thread app/assets/stylesheets/application.scss Outdated
@rshiggin

rshiggin commented Jun 22, 2026

Copy link
Copy Markdown
Member

I'd ideally like to remap color variables from Bootstrap to our design system variables. This would take a small chunk of code in bootstrap.scss.

@use 'bootstrap/scss/bootstrap' with (
  $primary: #1d7491,           // your teal-400
  $success: #20a848,           // your green-400
  $danger:  #d93838,           // your pink-400
  $warning: #ffcb05,           // your maize-400 (replaces dandelion!)
  $body-bg: #fff,
  $font-family-base: var(--font-base-family)
);

@use 'bootstrap-icons/font/bootstrap-icons';
@use "blacklight-frontend/app/assets/stylesheets/blacklight/blacklight";

Note: all the default Bootstrap 5 being pulled into our project is stored in node_modules/bootstrap.

@rshiggin

rshiggin commented Jun 22, 2026

Copy link
Copy Markdown
Member

re: SCSS deprecation warnings.

We're going to continue to see deprecation warnings from "@import" until "Project Blacklight" updates it's project to be fully Dart Sass compatible, which it will be forced to do with BS6.

Let's consider silencing these in package.json by adding "--quiet-deps"
"build:css:compile": "sass ... --no-source-map --load-path=node_modules --quiet-deps"

I've commited this f0eab7c

}
}

&.banner-shadow {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I removed a shadow block from homepage.scss for imgback. Not sure if that's a big deal but it didn't seem to be needed...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not a big deal. I don't think the shadow for imgback is in the template.

For the banner the shadow does the angled transition between darker yellow and lighter.

@rshiggin rshiggin changed the title Adopt home and repositories pages from umich-arclight, refactoring/updating as needed Adapt home and repositories pages from umich-arclight Jun 23, 2026
@ssciolla ssciolla marked this pull request as ready for review June 23, 2026 15:21
@ssciolla ssciolla merged commit 6e26ade into main Jun 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants