Adapt home and repositories pages from umich-arclight#22
Conversation
…Arclight::Repository
…verriding templates for index, home, adding HomepageHelper and CatalogHelper, adding image config and files, adding um_arclight translation file
Arc 135 repositories view edits
…ion.bootstrap; fix spacing in _home.html.erb
…his Site row in _home.html.erb
…home Tweak home spacing and code style
…mb divide to base.scss
ARC-134 refactor SCSS
| } | ||
|
|
||
| // Arclight, imported from arclight frontend package | ||
| @import 'arclight/app/assets/stylesheets/arclight/application'; |
There was a problem hiding this comment.
Do we no longer need this, or was it moved elsewhere?
There was a problem hiding this comment.
For now, I've left it out of our update with the assumption we don't need it. To make it easy for now there's just a flat directory, "stylesheets"
|
|
||
| /* ---------------------- */ | ||
| /* SEARCH BOX ON HOMEPAGE */ | ||
| /* ---------------------- */ |
There was a problem hiding this comment.
Remove the large comment or the search bar itself? Doesn't it make sense to keep it under "Find Archival Materials."
There was a problem hiding this comment.
Yeah, sorry, I think I just meant remove the commented code above this, not the Search box stuff.
There was a problem hiding this comment.
When CSS is minified in production all comments are removed. These comments are helpful in development.
|
I'd ideally like to remap color variables from Bootstrap to our design system variables. This would take a small chunk of code in Note: all the default Bootstrap 5 being pulled into our project is stored in |
|
re: SCSS deprecation warnings. We're going to continue to see deprecation warnings from "@import" until "Project Blacklight" updates it's project to be fully Dart Sass compatible, which it will be forced to do with BS6. Let's consider silencing these in package.json by adding "--quiet-deps" I've commited this f0eab7c |
…ect not fully compatible with Dart Sass
Update and pare down helpers
| } | ||
| } | ||
|
|
||
| &.banner-shadow { |
There was a problem hiding this comment.
I think I removed a shadow block from homepage.scss for imgback. Not sure if that's a big deal but it didn't seem to be needed...
There was a problem hiding this comment.
Probably not a big deal. I don't think the shadow for imgback is in the template.
For the banner the shadow does the angled transition between darker yellow and lighter.
…o homepage; remove ask a librarian, comment out alert in translation file
This PR aims to resolve JIRA ARC-135
Resources