Skip to content

fix: use dynamic port in server scenario tests to avoid conflicts #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
max-stytch wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −4
Open

fix: use dynamic port in server scenario tests to avoid conflicts #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions src/scenarios/server/all-scenarios.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,28 @@
import { spawn, ChildProcess } from 'child_process';
import { createServer } from 'net';
import { getClientScenario, listActiveClientScenarios } from '../index';
import path from 'path';

function getFreePort(): Promise<number> {
return new Promise((resolve, reject) => {
const server = createServer();
server.listen(0, () => {
const port = (server.address() as { port: number }).port;
server.close(() => resolve(port));
});
server.on('error', reject);
});
}

describe('Server Scenarios', () => {
let serverProcess: ChildProcess | null = null;
const TEST_PORT = 3001;
const SERVER_URL = `http://localhost:${TEST_PORT}/mcp`;
let serverUrl: string;
const SERVER_STARTUP_TIMEOUT = 30000; // 30 seconds for CI

beforeAll(async () => {
const testPort = await getFreePort();
serverUrl = `http://localhost:${testPort}/mcp`;

// Start the everything-server once for all scenarios in this file
const serverPath = path.join(
process.cwd(),
Expand All @@ -18,7 +32,7 @@ describe('Server Scenarios', () => {
// Use shell: true on Windows only (npx is npx.cmd on Windows)
const isWindows = process.platform === 'win32';
serverProcess = spawn('npx', ['tsx', serverPath], {
env: { ...process.env, PORT: TEST_PORT.toString() },
env: { ...process.env, PORT: testPort.toString() },
stdio: ['ignore', 'pipe', 'pipe'],
detached: false,
shell: isWindows
Expand Down Expand Up @@ -114,7 +128,7 @@ describe('Server Scenarios', () => {
throw new Error(`Scenario ${scenarioName} not found`);
}

const checks = await scenario.run(SERVER_URL);
const checks = await scenario.run(serverUrl);

// Verify checks were returned
expect(checks.length).toBeGreaterThan(0);
Expand Down