-
Notifications
You must be signed in to change notification settings - Fork 665
Make ClientTransportClosedException public and unify transport exception handling #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
10
commits into
main
Choose a base branch
from
copilot/fix-client-completion-details-access
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+253
−38
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
40c6dc8
Initial plan
Copilot d3f9b54
Make TransportClosedException public and propagate completion details…
Copilot aa218be
Address code review: fix null-safety on AggregateException.InnerExcep…
Copilot fde5d08
Remove redundant DisposeAsync call and simplify catch blocks in Creat…
Copilot a43d0d8
Remove unnecessary try/catch around Completion await
Copilot 8308c3b
Add Debug.Assert that Completion is already completed before awaiting it
Copilot 4983cfb
Separate read vs write failure tests and verify error logs
Copilot 2a5e1d7
Propagate caller-triggered cancellation in transport exception handling
Copilot 21319af
Rename TransportClosedException to ClientTransportClosedException
Copilot 6d9c086
Merge branch 'main' into copilot/fix-client-completion-details-access
stephentoub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
40 changes: 40 additions & 0 deletions
40
src/ModelContextProtocol.Core/Client/ClientTransportClosedException.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| using ModelContextProtocol.Protocol; | ||
| using System.Threading.Channels; | ||
|
|
||
| namespace ModelContextProtocol.Client; | ||
|
|
||
| /// <summary> | ||
| /// An <see cref="IOException"/> that indicates the client transport was closed, carrying | ||
| /// structured <see cref="ClientCompletionDetails"/> about why the closure occurred. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// <para> | ||
| /// This exception is thrown when an MCP transport closes, either during initialization | ||
| /// (e.g., from <see cref="McpClient.CreateAsync"/>) or during an active session. | ||
| /// Callers can catch this exception to access the <see cref="Details"/> property | ||
| /// for structured information about the closure. | ||
| /// </para> | ||
| /// <para> | ||
| /// For stdio-based transports, the <see cref="Details"/> will be a | ||
| /// <see cref="StdioClientCompletionDetails"/> instance providing access to the | ||
| /// server process exit code, process ID, and standard error output. | ||
| /// </para> | ||
| /// <para> | ||
| /// Custom <see cref="ITransport"/> implementations can provide their own | ||
| /// <see cref="ClientCompletionDetails"/>-derived types by completing their | ||
| /// <see cref="ChannelWriter{T}"/> with this exception. | ||
| /// </para> | ||
| /// </remarks> | ||
| public sealed class ClientTransportClosedException(ClientCompletionDetails details) : | ||
| IOException(details.Exception?.Message ?? "The transport was closed.", details.Exception) | ||
| { | ||
| /// <summary> | ||
| /// Gets the structured details about why the transport was closed. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// The concrete type of the returned <see cref="ClientCompletionDetails"/> depends on | ||
| /// the transport that was used. For example, <see cref="StdioClientCompletionDetails"/> | ||
| /// for stdio-based transports and <see cref="HttpClientCompletionDetails"/> for HTTP-based transports. | ||
| /// </remarks> | ||
| public ClientCompletionDetails Details { get; } = details; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 0 additions & 19 deletions
19
src/ModelContextProtocol.Core/Client/TransportClosedException.cs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.