mcp: accept parameterized Content-Type types #890
Open
kalvinnchau wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
mcp: accept parameterized Content-Type types #890kalvinnchau wants to merge 1 commit intomodelcontextprotocol:mainfrom
kalvinnchau wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
kalvinnchau
changed the title
atishpatel
approved these changes
Apr 9, 2026
jba
requested changes
Apr 10, 2026
mcp/streamable.go
Outdated
| default: | ||
| resp.Body.Close() | ||
| return fmt.Errorf("%s: unsupported content type %q", requestSummary, contentType) | ||
| return fmt.Errorf("%s: unsupported content type %q", requestSummary, resp.Header.Get("Content-Type")) |
Contributor
There was a problem hiding this comment.
should be baseMediaType.
So put it in a variable before the switch.
Contributor
Author
There was a problem hiding this comment.
thanks for the review, updated and rebased into a single commit
Use a shared helper for Content-Type parsing in streamable transport request validation and client response handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a shared helper for Content-Type parsing in streamable transport request validation and client response handling.
Follow up to #853, where we did this for
Acceptheaders.This allows the streamable mcp server to validate the following header
Content-Type: application/json;charset=utf-8