Skip to content

Add $runnerControl parameter to StdioTransport constructor #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nyholm wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −8
Open

Add $runnerControl parameter to StdioTransport constructor #205

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67f73ff
Add $runnerControl parameter to StdioTransport constructor
Nyholm Dec 27, 2025
f990768
fix cs
Nyholm Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/Server/Transport/StdioTransport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<?php

/*
Expand All @@ -24,21 +24,16 @@
*/
class StdioTransport extends BaseTransport
{
private RunnerControlInterface $runnerControl;

/**
* @param resource $input
* @param resource $output
* @param ?RunnerControlInterface $runnerControl
* @param resource $input
* @param resource $output
*/
public function __construct(
private $input = \STDIN,
private $output = \STDOUT,
?LoggerInterface $logger = null,
/* ?RunnerControlInterface $runnerControl = null, */
private readonly RunnerControlInterface $runnerControl = new RunnerControl(),
) {
// $runnerControl parameter was added in 0.2.1 and will be default in 0.3.0
$this->runnerControl = \func_get_args()[3] ?? new RunnerControl();
parent::__construct($logger);
}

Expand Down
Loading