Add missing handler for resource subscribe/unsubscribe handlers #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigdevlarry
requested review from
CodeWithKyrian,
Nyholm and
chr-hertel
as code owners
bigdevlarry
force-pushed
the
Add-missing-handler-for-Resource-Subscribe-Unsubscribe
branch
from
88d6e7a to
627f00b
Compare
bigdevlarry
force-pushed
the
Add-missing-handler-for-Resource-Subscribe-Unsubscribe
branch
from
627f00b to
95be722
Compare
bigdevlarry
commented
Jan 8, 2026
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| ini_set('display_errors', '0'); |
Contributor
Author
There was a problem hiding this comment.
This prevents PHP from printing errors to the response body fixes the JSON-RPC error of outputting html
bigdevlarry
commented
Jan 8, 2026
| /** | ||
| * @var array<string, array<string, SessionInterface>> | ||
| */ | ||
| private array $resourceSubscriptions = []; |
Contributor
Author
There was a problem hiding this comment.
How do we make the subscription persistent to make it work across multiple request?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing handler for resource subscribe/unsubscribe handlers
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context