Skip to content

feat: add theme field to Icon type for light/dark mode support #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gfortaine wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

feat: add theme field to Icon type for light/dark mode support #1978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/mcp/types/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
GetTaskRequestParams,
GetTaskResult,
Icon,
IconTheme,
ImageContent,
Implementation,
IncludeContext,
Expand Down Expand Up @@ -275,6 +276,7 @@
"BlobResourceContents",
"EmbeddedResource",
"Icon",
"IconTheme",
"ImageContent",
"ResourceContents",
"ResourceLink",
Expand Down
6 changes: 6 additions & 0 deletions src/mcp/types/_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
ProgressToken = str | int
Role = Literal["user", "assistant"]

IconTheme = Literal["light", "dark"]

TaskExecutionMode = Literal["forbidden", "optional", "required"]
TASK_FORBIDDEN: Final[Literal["forbidden"]] = "forbidden"
TASK_OPTIONAL: Final[Literal["optional"]] = "optional"
Expand Down Expand Up @@ -170,6 +172,10 @@ class Icon(MCPModel):
sizes: list[str] | None = None
"""Optional list of strings specifying icon dimensions (e.g., ["48x48", "96x96"])."""

theme: IconTheme | None = None
"""Optional theme specifier. 'light' indicates the icon is designed for a light
background, 'dark' indicates the icon is designed for a dark background."""


class Implementation(BaseMetadata):
"""Describes the name and version of an MCP implementation."""
Expand Down