Fix Streamable HTTP Accept negotiation#2364
Open
raashish1601 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Fix Streamable HTTP Accept negotiation#2364raashish1601 wants to merge 1 commit intomodelcontextprotocol:mainfrom
raashish1601 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application/jsonortext/event-streamfor Streamable HTTP POSTs when SSE-capable mode is enabledFixes #2349
Testing
$env:PYTHONPATH='src'; python -m pytest tests/shared/test_streamable_http.py -k "accept_header_validation or accept_header_wildcard or single_media_type_negotiates_response or accept_header_incompatible or json_response_accept_json_only"$env:PYTHONPATH='src'; python -m pytest tests/issues/test_1363_race_condition_streamable_http.py -k invalid_accept_headers$env:PYTHONPATH='src'; python -m pytest tests/shared/test_streamable_http.py -k "test_response or test_json_response or server_backwards_compatibility_no_protocol_version"python -m ruff check src/mcp/server/streamable_http.py tests/shared/test_streamable_http.py tests/issues/test_1363_race_condition_streamable_http.py