fix: align Context logging methods with MCP spec data type#2366
Open
paikend wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix: align Context logging methods with MCP spec data type#2366paikend wants to merge 2 commits intomodelcontextprotocol:mainfrom
paikend wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
Change `message: str` to `data: Any` in `Context.log()` and convenience
methods (debug, info, warning, error) to match the MCP specification
which allows any JSON-serializable type for log data.
Remove the `extra` parameter since callers can now pass structured data
directly (e.g., `ctx.info({"key": "value"})`).
Fixes modelcontextprotocol#397
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message: str→data: AnyinContext.log()and convenience methods (debug,info,warning,error)extraparameter — callers can now pass structured data directly asdataServerSession.send_log_message(data: Any)which already acceptsAnyMotivation
The MCP specification defines log data as
unknown(any JSON-serializable type), butContext.info()and friends only acceptedstr.Before:
After:
Breaking Change
messageparameter renamed todatainlog(),debug(),info(),warning(),error()extraparameter removed fromlog()and convenience methodsCallers using positional args (
ctx.info("msg")) are unaffected. Callers usingmessage=keyword orextra=need to update.Test plan
test_logging_callback.pyto use new APItest_context_loggingintest_server.pypasses (string data still works)Fixes #397
🤖 Generated with Claude Code