fix(filesystem): correct outputSchema for directory_tree and move_file #3166
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why this change was needed:
Both tools declared outputSchema as { content: z.string() } but their
handlers return { content: [{ type: "text", text: "..." }] } - an array
of content blocks. This mismatch caused MCP validation error -32602.
What changed:
- Updated directory_tree outputSchema to declare content as array of
text content blocks
- Updated move_file outputSchema with the same fix
- Schema now matches the actual return type of both handlers
Problem solved:
Clients using structured content validation no longer receive -32602
errors when calling directory_tree or move_file tools.
Fixes modelcontextprotocol#3093, Fixes modelcontextprotocol#3106
Author
|
Closing this PR - after investigation, the issues #3093 and #3106 were already fixed in commit 968acc2 (PR #3113). The issues just need to be closed. The existing tests in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
outputSchemadeclarations fordirectory_treeandmove_filetools to match their actual return types.Both tools were declaring
outputSchema: { content: z.string() }but returning{ content: [{ type: "text", text: "..." }] }- an array of content blocks. This mismatch caused MCP validation error-32602when clients used structured content validation.Changes
directory_treeoutputSchema to declare content as array of text content blocksmove_fileoutputSchema with the same fixTest plan
npm run buildin src/filesystem)Fixes #3093
Fixes #3106