fix(time): Fix McpError constructor usage in time server
#3222
+645
−185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes CI failures in PR modelcontextprotocol#3220. PR modelcontextprotocol#3220 updated `mcp` library from 1.0.0 to 1.23.0, which caused test failures due to a breaking change in `McpError` constructor API. The `McpError` constructor now expects an `ErrorData` object instead of a plain string message. This commit fixes the usage in `get_zoneinfo()` function to use `ErrorData(code=INVALID_PARAMS, message=...)`. ```console Error before fix: AttributeError: 'str' object has no attribute 'message' ``` Also updates `mcp` dependency to >=1.23.0 in pyproject.toml to ensure compatibility with the new API.
olaservo
approved these changes
Jan 17, 2026
Member
olaservo
left a comment
olaservo
left a comment
There was a problem hiding this comment.
Thanks! Wonder why this wasn't caught in the PR to update the sdk version.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes CI failures in PR #3220.
PR #3220 updated
mcplibrary from 1.0.0 to 1.23.0, which caused test failures due to a breaking change inMcpErrorconstructor API.The
McpErrorconstructor now expects anErrorDataobject instead of a plain string message. This commit fixes the usage inget_zoneinfo()function to useErrorData(code=INVALID_PARAMS, message=...).Also updates
mcpdependency to >=1.23.0 in pyproject.toml to ensure compatibility with the new API.How Has This Been Tested?
Automated tests were run against both the old and new versions of the
mcplibrary.Breaking Changes
None.
Types of changes
Checklist