fix(filesystem): describe tool parameters#4317
Open
go165 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds parameter-level descriptions to the filesystem server tools so
tools/listexposes enough schema detail for agents to choose correct argument values.The descriptions cover path shape and sandbox constraints, write/edit mutation scope, move source/destination behavior, and search/exclude glob semantics. This addresses #4095 for the filesystem server.
Server Details
Motivation and Context
Required filesystem tool parameters were exposed as typed schema properties without descriptions, so clients and agents had to infer whether values should be files, directories, glob patterns, or write content. The new descriptions make those expectations explicit in the MCP tool schema.
How Has This Been Tested?
npm run build -w src/filesystemnpm test -w src/filesystemI added an integration test that starts the built filesystem server and checks
tools/listto ensure every required tool parameter has a non-empty description.Breaking Changes
None.
Types of changes
Checklist
Additional context
No README update is needed because this only improves MCP tool schema metadata. I did not test with an LLM client; the regression test verifies the MCP
tools/listschema surfaced to clients.