fix(client): retry SSE stream after receiving session ID #1521
+417
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 6 tests for roots/list bidirectional request flow: - Successful request/response with client handler - Empty roots list handling - Multiple roots array - Optional name and _meta fields - sendRootsListChanged notification - Handler context verification
|
9 tasks
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Fixes server-initiated requests (roots/list, sampling, elicitation) hanging over HTTP transport. The client now retries opening the GET SSE stream after receiving a session ID during initialization. Fixes: modelcontextprotocol#1167
LucaButBoring
force-pushed
the
fix/roots-list
branch
from
34869be to
be20cd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes server-initiated requests (roots/list, sampling, elicitation) hanging over sHTTP when not issued as part of a client-to-server request. The client now retries opening the GET SSE stream after receiving a session ID during initialization.
Motivation and Context
Without this fix, sending requests to the client (particularly roots/elicitation requests) hangs on the server unless that is bounded by some other request, like a tool call. Naturally, this doesn't guarantee compatibility with any other SDK, but at least ensures that using the client and server from this SDK together works as intended.
How Has This Been Tested?
Updated unit/integration tests.
Breaking Changes
None.
Types of changes
Checklist
Additional context
Should fix #1167
v1 backport: #1520