feat: use scopes_supported from resource metadata by default (fixes #580)#757
Open
antogyn wants to merge 4 commits intomodelcontextprotocol:mainfrom
Open
feat: use scopes_supported from resource metadata by default (fixes #580)#757antogyn wants to merge 4 commits intomodelcontextprotocol:mainfrom
antogyn wants to merge 4 commits intomodelcontextprotocol:mainfrom
Conversation
0845a57 to
c94ba4b
Compare
pcarleton
requested changes
Sep 30, 2025
Member
pcarleton
left a comment
There was a problem hiding this comment.
Overall this change looks good (And consistent with SEP-835), but it has some conflicts with the main branch. if you're able to resolve those, we can merge this in.
8386834 to
42d0fd5
Compare
Author
|
Done, thanks for taking a look at this |
Author
|
Hey @pcarleton, is this still relevant? I resolved the conflicts last month but it didn't get merged, so now there are new conflicts, should I resolve them again or close the MR? |
Closed
Member
|
hey @antogyn sorry for the slow response. this is still necessary. i'll work on fixing the merge conflicts |
pcarleton
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If available, all scopes in the field
scopes_supportedfrom/.well-known/oauth-protected-resourceare used by default in:Motivation and Context
See #580
How Has This Been Tested?
I tested this on a custom build of mcp-remote and it works well for the authorization endpoint
I didn't test DCR though because it's not available in my setup, but if you have a suggestion to test it I can do that too
Breaking Changes
It can technically be breaking since the default value is different
Types of changes
Checklist
Additional context