Resolves the problems with zero system (#4654)#4656
Resolves the problems with zero system (#4654)#4656AHaumer wants to merge 12 commits intomodelica:masterfrom
Conversation
Modelica/Electrical/Machines/BasicMachines/Components/ZeroImpedance.mo
Outdated
Show resolved
Hide resolved
Modelica/Electrical/Machines/Interfaces/PartialBasicInductionMachine.mo
Outdated
Show resolved
Hide resolved
Modelica/Magnetic/FundamentalWave/BasicMachines/Components/SymmetricPolyphaseWinding.mo
Outdated
Show resolved
Hide resolved
|
@christiankral I followed your suggestions, but the description of the Boolean parameter should rather be: |
Good point. |
|
quick comment: is there a good reason to call the new model ZeroImpedance when the previous (somewhat related) was called ZeroInductor? I do understand that there's a bit of difference between the two. |
First: everything is 100% backwards compatible. |
|
@AHaumer according to Modelica.UsersGuide.Conventions.ModelicaCode.Format, we should have something like Boolean useZeroSystem=true "= true if zero current is explicitly computed"; |
|
Now I've corrected descriptions string of useZeroSystem according to Conventions. |
HansOlsson
left a comment
There was a problem hiding this comment.
Looks good, but might add annotation(Evaluate=true); to the parameter as it normally should be evaluated.
Modelica/Electrical/Machines/BasicMachines/Components/ZeroImpedance.mo
Outdated
Show resolved
Hide resolved
…dance.mo Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Implementing a Boolean parameter useZeroSystem to be able to suppress the calculation of the zero current (set to zero).
Backwards compatible: Default = true. In 3 examples (Modelica.Electrical.Machines.Examples.InductionMachines.IMC_YD, Modelica.Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines.IMC_YD, Modelica.QuasiStatic.Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines.IMC_YD) used to resolve numerical issues as reported in #4654 and #4486. Setting the attribute nominal = 10 (#4486) has been removed again.
Should we backport this to maintenance/4.1.0 ?