-
Notifications
You must be signed in to change notification settings - Fork 18
feat(WebSandbox): add custom event to allow sending notifications from sandbox to Python
#113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e58779e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @Col0ring, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new custom event for the WebSandbox component, allowing communication from the sandboxed environment back to the Python backend, and also fixes an issue with the drop container in the MultimodalInput component. The changes look good and the new feature is well-documented with a demo. I've found one minor issue in the documentation which I've commented on.
| | `pro.WebSandbox.compile_success(fn, ···)` | Triggered when Sandbox compilation succeeds. | | ||
| | `pro.WebSandbox.compile_error(fn, ···)` | Triggered when Sandbox compilation fails. | | ||
| | `pro.WebSandbox.render_error(fn, ···)` | Triggered when Sandbox rendering throws an error. | | ||
| | `pro.WebSandbox.render_error(fn, ···)` | Triggered when Sandbox rendering throws an error. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
custom event to allow sending notifications from sandbox to Python & fix drop container of MulimodalInputcustom event to allow sending notifications from sandbox to Python
No description provided.