Add TrackBar and ColorDialog with ARGB support, Timer, and UI improvements#100
Closed
ProGraMajster wants to merge 0 commit intomodern-forms:mainfrom
Closed
Add TrackBar and ColorDialog with ARGB support, Timer, and UI improvements#100ProGraMajster wants to merge 0 commit intomodern-forms:mainfrom
ProGraMajster wants to merge 0 commit intomodern-forms:mainfrom
Conversation
jpobst
reviewed
Mar 29, 2026
Collaborator
jpobst
left a comment
jpobst
left a comment
There was a problem hiding this comment.
There's a lot of good stuff here, but there are also some things that need to be changed. Trying to review and fix stuff in a 4k line PR probably isn't going to work. Let's split this up into several smaller PRs.
A few issues I see from a quick test are that things don't work correctly when using resolution scaling (I use 150%):
Also all the scrollbars are gone on ScrollableControl:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
ColorDialogimplementation with support for HSV, HSL and ARGB color models.It also includes: