refactor: use import type for type-only imports#3052
Open
bennypowers wants to merge 2 commits into
Open
Conversation
|
bennypowers
force-pushed
the
node24/import-type
branch
from
3ea8652 to
5594d8f
Compare
This was referenced Mar 26, 2026
bennypowers
force-pushed
the
node24/import-type
branch
3 times, most recently
from
9658001 to
40d0748
Compare
Member
Author
|
We should be able to ignore the test failures on node 22:
|
web-padawan
approved these changes
Mar 26, 2026
5 tasks
Add explicit `type` annotations to all type-only imports and exports. This is a pure TypeScript syntax change with no runtime effect -- the compiled JavaScript output is identical. It prepares for Node 24's type stripping, which requires `import type` for type-only imports since they are erased at runtime. 93 files changed across dev-server, test-runner, rollup-plugin, and storybook packages. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bennypowers
force-pushed
the
node24/import-type
branch
3 times, most recently
from
366c890 to
33a92c0
Compare
Node 22.18+ enables type stripping by default, preempting ts-node and causing __dirname to be undefined when detect-module reparses test files as ESM. Disable native strip-types so ts-node handles .ts files until mocha is replaced with node:test. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bennypowers
force-pushed
the
node24/import-type
branch
from
33a92c0 to
5f48b6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
import type/export typeannotations to type-only imports across 85 source files. No runtime effect.PR 1/4 in the Node 24 migration:
import typeannotations.tsimports