Upgrade Symfony dependencies to v7 #461
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do ?
Upgrade Symfony requirements to version 7 and make sure all commands are compatible.
This also fixes an issue I had where the
build --forcecommand was no longer working.Why is it needed ?
I still don't fully understand how all this Composer machinery operates, but I am running into more and more compatibility issues (not just with Gitify). For some reason, Gitify is using a higher version (v6 or v7) of Symfony console sometimes, if autoloaded by another extra. These versions contain breaking changes, leading to fatal errors for some commands.
This is from an extract after adding a Composer package to an extra, which depends on Symfony 7 stuff. The error messages reference the foreign vendor folder:
I suppose I could try to make Gitify stick to its own autoloader, but that feels a bit hacky. It probably makes more sense to adjust the commands so they become compatible with the higher Symfony versions. Or am I missing something, and is it pinned on Symfony 5 for a reason?
Anyway, I hope this will help for anyone else experiencing similar issues..