fix(mongodb-runner): handle arbiter RS convergence race in metadata check#770
Open
blink1073 wants to merge 4 commits into
Open
fix(mongodb-runner): handle arbiter RS convergence race in metadata check#770blink1073 wants to merge 4 commits into
blink1073 wants to merge 4 commits into
Conversation
…heck When a replica set is initiated, the code only waits for a PRIMARY to appear before proceeding to assertAllServersHaveInsertedLocalMetadata(). An arbiter node may still be transitioning to ARBITER state at that point, so hello.arbiterOnly can be undefined while this.isArbiter is already true, causing an immediate "Arbiter flag mismatch" throw. Fix _ensureMatchingMetadataColl to retry via eventually() when isArbiter is true but hello has not yet confirmed arbiterOnly, giving the member time to converge. Also handle the deserialize() ordering where isArbiter is set after _populateBuildInfo runs by skipping the check when hello.arbiterOnly is true regardless of the local flag. Add unit tests covering the retry path, immediate-success path, timeout propagation, and the deserialize ordering edge case.
|
Coverage is 78.727% — blink1073:check-arbiter-race-condition into mongodb-js:main. No base build found for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an intermittent failure when starting a replica set with an arbiter. After
replSetInitiate, an arbiter node may still be transitioning toARBITERstate whenassertAllServersHaveInsertedLocalMetadata()runs, causing a spurious "Arbiter flag mismatch" error. The fix retries thehellocheck until the member converges (or a timeout is reached), and also handles an ordering edge case indeserialize().Tracked in https://jira.mongodb.org/browse/DRIVERS-3538.
Open Questions
None.
Checklist