Skip to content

fix(NODE-6642): include source build script in published package#112

Closed
tadjik1 wants to merge 1 commit into
mainfrom
fix/NODE-6642-include-build-script-in-package
Closed

fix(NODE-6642): include source build script in published package#112
tadjik1 wants to merge 1 commit into
mainfrom
fix/NODE-6642-include-build-script-in-package

Conversation

@tadjik1
Copy link
Copy Markdown
Contributor

@tadjik1 tadjik1 commented May 21, 2026

Description

Summary of Changes

etc/install-zstd.sh was missing from the files array in package.json, so it was never included in the published npm package.

When prebuild-install cannot find a prebuilt binary (e.g. Node 24 on Windows, or any unsupported platform/architecture combination), the install falls back to npm run clean-installnpm run install-zstdbash etc/install-zstd.sh. Without the script present, this fails with:

bash: etc/install-zstd.sh: No such file or directory
exit code 127

This fix adds etc/install-zstd.sh to the files array. etc/docker.sh is intentionally excluded as it is a CI utility not needed for package installation.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: `feat(NODE-1234)!: rewriting everything in coffeescript`
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@tadjik1 tadjik1 requested a review from a team as a code owner May 21, 2026 12:27
Copilot AI review requested due to automatic review settings May 21, 2026 12:27
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the npm package contents by ensuring the source-build fallback script (etc/install-zstd.sh) is included in the published tarball, so prebuild-install fallback installs don’t fail when no prebuilt binary is available.

Changes:

  • Add etc/install-zstd.sh to the files allowlist in package.json so it is published to npm.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tadjik1
Copy link
Copy Markdown
Contributor Author

tadjik1 commented May 21, 2026

Duplicate of #110 which has the identical fix. Closing in favour of that PR.

@tadjik1 tadjik1 closed this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants