fix(NODE-6642): include source build script in published package#112
Closed
tadjik1 wants to merge 1 commit into
Closed
fix(NODE-6642): include source build script in published package#112tadjik1 wants to merge 1 commit into
tadjik1 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the npm package contents by ensuring the source-build fallback script (etc/install-zstd.sh) is included in the published tarball, so prebuild-install fallback installs don’t fail when no prebuilt binary is available.
Changes:
- Add
etc/install-zstd.shto thefilesallowlist inpackage.jsonso it is published to npm.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Duplicate of #110 which has the identical fix. Closing in favour of that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
etc/install-zstd.shwas missing from thefilesarray inpackage.json, so it was never included in the published npm package.When
prebuild-installcannot find a prebuilt binary (e.g. Node 24 on Windows, or any unsupported platform/architecture combination), the install falls back tonpm run clean-install→npm run install-zstd→bash etc/install-zstd.sh. Without the script present, this fails with:This fix adds
etc/install-zstd.shto thefilesarray.etc/docker.shis intentionally excluded as it is a CI utility not needed for package installation.Double check the following
npm run check:lint)type(NODE-xxxx)[!]: description