refactor: remove jq from simple-modals (@miodec) #7307
Merged
+28
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the simple-modal utility to remove jQuery dependencies, replacing jQuery calls with native DOM utility methods. The changes also fix bugs that were introduced in PR #7303.
Key Changes
- Replaced jQuery (
$) calls with native DOM utilities (qs,qsa, and ElementWithUtils methods) - Added a
setValuemethod toElementsWithUtilsclass for setting input values across multiple elements - Introduced a module-level constant
simpleModalElfor cleaner DOM access
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/ts/utils/simple-modal.ts | Refactored to replace all jQuery calls with native DOM utilities (qs, qsa) and ElementWithUtils methods, added simpleModalEl constant |
| frontend/src/ts/utils/dom.ts | Added setValue method to ElementsWithUtils class to support setting values on multiple input/textarea elements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes bugs added in #7303