Skip to content

refactor(popups): Remove jQuery from popups (@thanoskn) #7321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Miodec merged 9 commits into from
Jan 7, 2026
Merged

refactor(popups): Remove jQuery from popups (@thanoskn) #7321

Miodec merged 9 commits into from
Jan 7, 2026
+9 −8

Conversation

@thanoskn
Copy link
Contributor

@thanoskn thanoskn commented Jan 6, 2026

Description

Replace jQuery with dom utils

Checks

  • Adding/modifying Typescript code?
    • I have used qs, qsa or qsr instead of JQuery selectors.
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Related #7186

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jan 6, 2026
@thanoskn thanoskn marked this pull request as ready for review January 6, 2026 17:36
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Jan 6, 2026
@thanoskn thanoskn marked this pull request as draft January 6, 2026 17:38
@github-actions github-actions bot removed the waiting for review Pull requests that require a review before continuing label Jan 6, 2026
@thanoskn thanoskn marked this pull request as ready for review January 6, 2026 20:39
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Jan 6, 2026
Leonabcd123
Leonabcd123 suggested changes Jan 7, 2026
View reviewed changes
@github-actions github-actions bot removed the waiting for review Pull requests that require a review before continuing label Jan 7, 2026
@Miodec Miodec merged commit 33d5605 into monkeytypegame:master Jan 7, 2026
14 checks passed
@thanoskn thanoskn deleted the remove-JQuery-from-popups branch January 7, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Miodec Miodec Miodec approved these changes

+1 more reviewer

@Leonabcd123 Leonabcd123 Leonabcd123 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

frontend User interface or web stuff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thanoskn @Miodec @Leonabcd123 @monkeytypegeorge