Open
Conversation
Contributor
Author
|
@MarqRazz ping |
MarqRazz
reviewed
Nov 3, 2025
Contributor
MarqRazz
left a comment
MarqRazz
left a comment
There was a problem hiding this comment.
Sorry for the delay on getting you a review I was off traveling. I don't think we normally support distros directly in the code like this, can't we just not port this change to the Galactic and older branches?
Contributor
Author
|
@MarqRazz I agree with your reasoning. I followed the method used in the moveit2 repository. |
Contributor
If we are not going to port this back to Galactic why do we need the if else in the include? |
MarqRazz
approved these changes
Nov 6, 2025
Contributor
|
FYI, I can't merge this with the required test failing even though it has nothing to do with this PR. I don't have high enough permissions. |
using tf2 *.h hesders is deprecated ->switch to *.hpp
Co-authored-by: Marq Rasmussen <marq.razz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
using tf2 *.h hesders is deprecated ->switch to *.hpp
Checklist