fix: cmd-shim not identified if placed outside node_modules/.bin/#158
Open
patrickkfkan wants to merge 3 commits intomoxystudio:masterfrom
Open
fix: cmd-shim not identified if placed outside node_modules/.bin/#158patrickkfkan wants to merge 3 commits intomoxystudio:masterfrom
node_modules/.bin/#158patrickkfkan wants to merge 3 commits intomoxystudio:masterfrom
Conversation
Author
|
Revisiting this, I realize the I'll leave it to the project devs to decide what to do with this PR. |
mike22664
approved these changes
Feb 21, 2025
sara554-beep
approved these changes
Mar 19, 2025
sara554-beep
approved these changes
Mar 19, 2025
sara554-beep
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a node executable installed globally with
npm i -g. Because of this, the cmd-shim was not placed innode_modules/.bin/. On Windows, this causedcross-spawnto escape arguments only once.This PR inspects the contents of the target file and if it can obtain the wrapped command, it will take it as cmd-shim and escape arguments twice.