Open
Conversation
isabelrios
commented
Jan 31, 2017
| it('should login if password is correct', function () { | ||
| // The password should be the one used in server -> dev.json file | ||
| return loginView.correctPassword('PasswordSet') | ||
| }); |
Author
There was a problem hiding this comment.
Not sure how we can set a default password for the tests. If it depends on the one created in dev.json, could we have that file by default? Or could there be another way?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First approach to have some ui tests. So far they have to ben run manually, I edited the readme file with the command. I can work to add them to travis but wanted to check this first approach.
Also, I have a question about some configurations to make them pass.
@ferjm please r? when you have some time.
Thanks!