add cinder runbook#25013
Open
eviljeff wants to merge 2 commits into
Open
Conversation
eviljeff
force-pushed
the
15639-cinder-runbook
branch
from
88f66f6 to
0cbac87
Compare
eviljeff
force-pushed
the
15639-cinder-runbook
branch
from
0cbac87 to
f58145b
Compare
eviljeff
requested review from
a team,
chrstinalin and
diox
and removed request for
a team
Member
Author
|
Christina has been allocated the review - along with the general r? I'd be interested to know if this explains Cinder to you, as someone who was not already familiar with it. Mat - I'm interested, does this "fit" with our existing docs, is it written as a runbook, should it be somewhere else in the docs, (should it be split up?) etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#15639
Description
Adds a runbook for Cinder.
Context
I also tinkered with the runbooks in general - despite the instructions, defining the steps with ## Steps and then the steps at level 3 means the TOC doesn't show the step names.
After writing this file, I'm not sure if it should live in runbooks or elsewhere - it's part explainer, part runbook? Suggestions welcome. About the structure/content too.
Testing
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.