fix(build): set target_arch to fix NSS build on Apple Silicon#6713
Open
groovecoder wants to merge 1 commit intomozilla:mainfrom
Open
fix(build): set target_arch to fix NSS build on Apple Silicon#6713groovecoder wants to merge 1 commit intomozilla:mainfrom
groovecoder wants to merge 1 commit intomozilla:mainfrom
Conversation
GYP expects the `target_arch` environment variable to determine the correct architecture when building NSS. On Apple Silicon, if this is unset or misconfigured, NSS can be built for `x86_64`, leading to linker failures due to architecture mismatch. This patch sets `target_arch` based on `uname -m` when building on macOS, ensuring correct architecture selection and avoiding these build errors.
c568c0b to
2ebfb5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GYP expects the
target_archenvironment variable to determine the correct architecture when building NSS. On Apple Silicon, if this is unset or misconfigured, NSS can be built forx86_64, leading to linker failures due to architecture mismatch.This patch sets
target_archbased onuname -mwhen building on macOS, ensuring correct architecture selection and avoiding these build errors.Pull Request checklist
For changes that need extra cross-platform testing, consider adding[ci full]to the PR title.If this pull request includes a breaking change, consider cutting a new release after merging.Any breaking changes to Swift or Kotlin binding APIs are noted explicitlyBranch builds: add
[firefox-android: branch-name]to the PR title.