feat(ads-client): retry callback requests once on transient transport failure#7361
Draft
Almaju wants to merge 1 commit into
Draft
feat(ads-client): retry callback requests once on transient transport failure#7361Almaju wants to merge 1 commit into
Almaju wants to merge 1 commit into
Conversation
… failure `recordImpression`, `recordClick`, and `reportAd` are fire-and-forget calls that consumers can't easily redo. On unreliable mobile networks they were silently lost on a single timeout, connection reset, or DNS hiccup. Retry the request once after a 500ms wait when viaduct reports a transport-level error. HTTP status errors are intentionally not retried — those are application decisions, not transient blips. Extracted as a small `retry_once` helper so the retry policy is testable without needing to fake a viaduct backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recordImpression,recordClick, andreportAdare fire-and-forget calls — once a consumer hands them off, they have no easy way to know whether to retry. On flaky mobile networks (timeouts, brief connection resets, DNS hiccups), a single transport-level failure currently drops the callback silently.This adds a single retry, 500ms after the first attempt, when
viaduct::ViaductErroris returned. HTTP status errors (4xx/5xx) are not retried — those are application decisions, not transient blips.The retry policy is a small free function (
retry_once) so the behaviour is unit-testable without faking a viaduct backend.Pull Request checklist
[ci full]to the PR title.