Bug 2039737 - Adds kotlin bindings for add_many in logins.#7371
Open
boek wants to merge 1 commit into
Open
Conversation
segunfamisa
reviewed
May 15, 2026
Comment on lines
+106
to
+107
| usernameField = "users_name", | ||
| passwordField = "users_password", |
Contributor
There was a problem hiding this comment.
is this always going to be users_name and users_password ?
Contributor
Author
There was a problem hiding this comment.
I just copied the fake data that already existed in test. I'm not sure exactly what these fields are used for.
segunfamisa
approved these changes
May 15, 2026
Contributor
segunfamisa
left a comment
segunfamisa
left a comment
There was a problem hiding this comment.
From a Kotlin POV, this looks good to me. I don't know about the A-S layer, so I'll leave that to the code owners.
Contributor
Author
|
@mhammond could we get a review on this one? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
[ci full]to the PR title.