Bug2007406 - Add server knobs config to ping_info#3396
Draft
travis79 wants to merge 1 commit intomozilla:mainfrom
Draft
Bug2007406 - Add server knobs config to ping_info#3396travis79 wants to merge 1 commit intomozilla:mainfrom
travis79 wants to merge 1 commit intomozilla:mainfrom
Conversation
This adds the currently applied server knobs config to all pings in the ping_info section, or omits it if no server knobs config is applied. This should help to calculate effective sampling rates for metrics and pings that are being sampled in the client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the currently applied server knobs config to all pings in the ping_info section, or omits it if no server knobs config is applied. This should help to calculate effective sampling rates for metrics and pings that are being sampled in the client.
Schema update PR is here: mozilla-services/mozilla-pipeline-schemas#857