Fix flaky LambdaSyntaxTest#460
Draft
braguex10 wants to merge 1 commit into
Draft
Conversation
Author
|
Fixes #443. |
mpostol
added
question
In progress
In waiting
Owner
|
I am not sure if the main goal for this example is preserved. Since it affects the master branch, it has to wait for the next tag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #443.
The LambdaSyntaxTest previously used Random to generate test data. Because of that, the number of values greater than or equal to 50 could occasionally fall outside the expected tolerance, causing the test to fail randomly.
The test data is now deterministic. The buffer contains exactly half values below 50 and half values greater than or equal to 50. This keeps the purpose of the test, which is to verify the lambda expression used by Count, while removing the random behavior.