Fix race condition in MultisynqRoot session creation#1
Open
Veenoway wants to merge 1 commit intomultisynq:mainfrom
Open
Fix race condition in MultisynqRoot session creation#1Veenoway wants to merge 1 commit intomultisynq:mainfrom
Veenoway wants to merge 1 commit intomultisynq:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
Problem
The
setSessionmethod inMultisynqRootcomponent had a race condition when called multiple times rapidly, potentially creating multiple sessions without proper cleanup.Solution
Added error handling and session validation in
setSession:nextSessionRefleave()if another session was created in the meantimeChanges
createMultisynqSession(args)if (nextSessionRef.current === null)newSession.leave()for abandoned sessionsManual Testing
Verified that concurrent
setSessioncalls don't create session leaks.Breaking Changes
None - this is a backwards-compatible bug fix.