Open
Conversation
…vent out-of-bounds errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR expands the possibilities for vehicle variants, increasing the available base limit from 6 to 253.
(254 = random default variant, 255 = reset variants)
Extras are indexed starting from 1, so for example, extra40 will be variant 39.
By default, GTA:SA can handle extras from
extra1toextra5. With this update, modelers can now useextra6throughextra253, and MTA will handle these natively. These components should be added tochassis_dummylike other variants.Motivation
Currently, vehicle variants are quite limited by default. We use many vehicles where multiple types of the same model are available as separate variants, but often the default 6 variants are not enough, forcing us to rely on custom element data. This solution is much more performance-oriented and, incidentally, can natively handle 253 extra components without scripts.
Furthermore, in our case, there is no need to rely on custom element data, as the built-in synchronization manages this automatically.
Test plan
Start the attached resource and run
setVehicleVariant(vehicle, 99, 39)replace.zip
Checklist