Fix isElementOnScreen for markers#4771
Open
FileEX wants to merge 10 commits intomultitheftauto:masterfrom
Open
Fix isElementOnScreen for markers#4771FileEX wants to merge 10 commits intomultitheftauto:masterfrom
FileEX wants to merge 10 commits intomultitheftauto:masterfrom
Conversation
…the new parser" This reverts commit bb936f2.
Collaborator
|
I have tested this with all 5 marker types and it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to use the
isElementOnScreenfunction for markers.Known issues
When rendering 3D markers, GTA checks visibility using a fixed radius of 2.0. This causes a bug where large markers disappear/flicker when moving the camera.
A second bug concerns this PR itself -
isElementOnScreenreturns true even when the marker is not visible but is close to the edge of the camera. The reason is simple: the marker is not visible, but GTA still renders it because the camera is within the 2-unit radius. This can be fixed in a future PR.Motivation
Fixes #2029
Test plan
Checklist