[4.7.x] Fix finding external Musical Text Fonts and their metadata.json files#33763
Open
Jojo-Schmitz wants to merge 2 commits into
Open
[4.7.x] Fix finding external Musical Text Fonts and their metadata.json files#33763Jojo-Schmitz wants to merge 2 commits into
Jojo-Schmitz wants to merge 2 commits into
Conversation
if those don't have a space before the "Text" in their filename
So far all fonts I've encountered have their metadata.json named "FontName.json" (mixed case, possible containing spaces, same as the fontname itself, the only documented option for non-private fonts), "fontname_metadata.json" (all lowercase, no spaces) or "metadata.json" (lowercase), so let's search for these, in that order and stop at the 1st hit. As a last reseort leave the previous iteration method (which stops at the last match for "*.json").
Jojo-Schmitz
force-pushed
the
4.7-external-smulf-fonts
branch
from
5c480d2 to
0fc75df
Compare
Jojo-Schmitz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #33757