Re-design PropertiesPanelTabButtons to hug contents instead of having equal widths#33765
Open
ajuncosa wants to merge 1 commit into
Open
Re-design PropertiesPanelTabButtons to hug contents instead of having equal widths#33765ajuncosa wants to merge 1 commit into
ajuncosa wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR advances the muse submodule to a new commit and updates the properties panel tab UI: PropertiesPanelTabBar now computes a readonly truncatedItemWidth via computeTruncatedItemWidth(), and PropertiesPanelTabButton stops using fillWidth and instead limits its width to Math.min(implicitWidth, tabBar.truncatedItemWidth) when a tabBar is present. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsLinked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@muse`:
- Line 1: Update the PR description to clarify the submodule bump: explicitly
state that the change in muse/muse_framework (commit 65edd4a8... -> 6eadd9e0...)
only adds tooltips in StyledTabButton.qml and explain whether this tooltip
addition is part of the truncated-text/tab button fix for issue `#32604`; if it is
not related, split the tooltip change into its own PR referencing
StyledTabButton.qml and the specific commit so reviewers can review it
independently.
In
`@src/propertiespanel/qml/MuseScore/PropertiesPanel/common/PropertiesPanelTabButton.qml`:
- Around line 35-37: The overflow check in the calculation of
tabBarContentImplicitWidth omits the spacing between tabs, so update the reduce
logic that computes tabBarContentImplicitWidth (or compute a new total) to add
the total spacing: include tabBar.spacing * Math.max(0,
tabBar.contentChildren.length - 1) when comparing against tabBar.width; ensure
you reference tabBar.contentChildren.reduce (or the tabBarContentImplicitWidth
variable) and use tabBar.spacing and tabBar.contentChildren.length so truncation
correctly triggers when widths plus spacing exceed tabBar.width.
- Around line 35-50: PropertiesPanelTabButton.qml currently uses
tabBar.contentChildren and tabBar.count (variables tabBarContentImplicitWidth,
widthLimitForTruncation, huggedItems) which include hidden buttons; change the
math to only consider visible buttons by filtering tabBar.contentChildren with
button.visible to compute visibleChildren, visibleCount,
visibleContentImplicitWidth and visible huggedItems, then replace uses of
tabBar.count, total sums and spacing with these visible-aware values so
truncation and width distribution ignore hidden tabs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 38e02acd-78cb-48e5-91a2-d2af07b2fa5b
📒 Files selected for processing (2)
musesrc/propertiespanel/qml/MuseScore/PropertiesPanel/common/PropertiesPanelTabButton.qml
ajuncosa
force-pushed
the
truncated-text
branch
2 times, most recently
from
1abb41e to
0a3db75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #32604
Related to muse_framework: musescore/muse_framework#82 (Add tooltips to StyledTabButton)
Instead of evenly dividing the available tab bar width amongst the tab buttons, the buttons' width now fits their content (up to a maximum).
If the sum of the widths of all buttons surpasses the available tab bar width, then we identify some buttons to truncate by looking for buttons which surpass a threshold (this process may take multiple iterations).
Then, the widths of the buttons which are not to be truncated, simply fit their contents. The remaining tab bar width which is not occupied by "fitted" items is equally distributed amongst the "too wide" items, and their text is truncated accordingly.